#16004: Update notebook to utilize pure javascript JSmol for default live 3-D
-------------------------------------------------+-------------------------
       Reporter:  gutow                          |        Owner:  gutow
           Type:  enhancement                    |       Status:
       Priority:  major                          |  needs_review
      Component:  notebook                       |    Milestone:  sage-6.4
       Keywords:  Jmol 3D 3-D                    |   Resolution:
        Authors:  Jonathan Gutow, Volker Braun   |    Merged in:
Report Upstream:  Reported upstream. Developers  |    Reviewers:
  acknowledge bug.                               |  Work issues:
         Branch:                                 |       Commit:
   Dependencies:  #17020                         |     Stopgaps:
-------------------------------------------------+-------------------------

Comment (by kcrisman):

 Testing - more impressions, now from the main stuff.
  * In right-click menu, Jmol version is still 14.0.13 - presumably still
 hard-coded.
  * The "make new cell interface" icons look much better than before, but
 it is STILL a different color from before and a different cell height.  In
 particular, the commit
 
https://github.com/vbraun/sagenb/commit/8fe8371b93112d29a4096307d5807d736c41e415
 breaks it, and
 
https://github.com/vbraun/sagenb/commit/f9760a8635a63511731e340046711b1a7288de1c
 "fixes" it but not really.
  * Shift-click is still broken, because Volker just took your commits but
 didn't fix them.  See
 
https://github.com/kcrisman/sagenb/commit/4fe29c8f7ab6ae5a44bf9a51872b3008ee4d18a2
 for a commit that (perhaps with minor modifications) fix this - I think I
 actually got it from Jonathan but perhaps modified it, that was a while
 ago now.
  * The new cell bar, when it is ''below'' a text area, does not have the
 icons.

 Please do check out what I did to keep behavior as close to the legacy as
 possible.  Hopefully it will be pretty easy for one of you to just import
 'correct' behavior.  It would have been easier to have not touched that
 stuff at all, but I know that ship has sailed.  Also, if we need to move
 discussion to github that is fine, I'm putting it here because I know
 everyone is reading this :)

--
Ticket URL: <http://trac.sagemath.org/ticket/16004#comment:89>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica, 
and MATLAB

-- 
You received this message because you are subscribed to the Google Groups 
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.

Reply via email to