#17163: Speed improvement for DiGraph.in_degree
-------------------------+-------------------------------------------------
       Reporter:         |        Owner:
  ncohen                 |       Status:  needs_review
           Type:         |    Milestone:  sage-6.4
  defect                 |   Resolution:
       Priority:  major  |    Merged in:
      Component:  graph  |    Reviewers:  David Coudert
  theory                 |  Work issues:
       Keywords:         |       Commit:
        Authors:         |  303ad6cc6643b491f160b539c0750153a8158486
  Nathann Cohen          |     Stopgaps:
Report Upstream:  N/A    |
         Branch:         |
  u/ncohen/17163         |
   Dependencies:         |
-------------------------+-------------------------------------------------
Changes (by dcoudert):

 * reviewer:   => David Coudert


Comment:

 The patch is working well. However, there are several places in
 {{{src/sage/graphs/base/c_graph.pyx}}} where you have such instruction
 (this one from your patch):

 {{{
 cdef v_int = get_vertex(v,
                         self.vertex_ints,
                         self.vertex_labels,
                         self._cg)
 }}}

 Shouldn't you specify the ''int'' type ?

--
Ticket URL: <http://trac.sagemath.org/ticket/17163#comment:4>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica, 
and MATLAB

-- 
You received this message because you are subscribed to the Google Groups 
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.

Reply via email to