#17179: TIDES interface should convert exact parameters to floating points.
-------------------------------------+-------------------------------------
Reporter: mmarco | Owner:
Type: defect | Status: needs_work
Priority: major | Milestone: sage-6.4
Component: interfaces | Resolution:
Keywords: | Merged in:
Authors: | Reviewers:
Report Upstream: N/A | Work issues:
Branch: | Commit:
u/mmarco/ticket/17179 | fb97dfead7efb0375969dc048cf2fe8f752564e8
Dependencies: | Stopgaps:
-------------------------------------+-------------------------------------
Changes (by jdemeyer):
* status: needs_review => needs_work
Comment:
Some comments:
* Instead of `mkdtemp()`, you can use `tmp_dir()` from
`sage.misc.temporary_file`. That gets cleaned automatically.
* Instead of `TIDES_RND`, I would use an explicit `MPFR_RNDN` instead in
the `mpfr_set_str()` calls.
* Removed the unused import of `SAGE_ROOT`.
* Do you really need `RR(SR(foo))`, isn't `RR(foo)` sufficient?
* Tides uses
{{{
int binary_precision(int prec) {
return ceil(prec * 3.3219);
}
}}}
to convert from decimal to binary precision, perhaps you should use the
same formula?
* You should use the `.str(truncate=False)` method to convert a
`RealNumber` to a string, because by default Sage prints reals with less
digits. Compare
{{{
sage: RR(pi).str(truncate=False)
'3.1415926535897931'
sage: RR(pi).str()
'3.14159265358979'
}}}
* Then something unrelated to this ticket: `exp()` in an expression
currently doesn't work.
* Finally, fill in your real name as author on this ticket.
--
Ticket URL: <http://trac.sagemath.org/ticket/17179#comment:5>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.
