#17153: Print the git branch when doctesting
-------------------------------------+-------------------------------------
Reporter: jhpalmieri | Owner:
Type: enhancement | Status: needs_review
Priority: major | Milestone: sage-6.4
Component: doctest framework | Resolution:
Keywords: | Merged in:
Authors: John Palmieri | Reviewers: Jeroen Demeyer
Report Upstream: N/A | Work issues:
Branch: | Commit:
u/jhpalmieri/print_branch | 3ccc895dc14ea8c702d25b4f98c4740c6f1139b7
Dependencies: | Stopgaps:
-------------------------------------+-------------------------------------
Changes (by jhpalmieri):
* status: needs_work => needs_review
Comment:
Replying to [comment:3 jdemeyer]:
> `./sage --git-branch` prints the branch and then does other stuff. Is
this intentional?
No, that was a mistake. I'm adding an `exec` to the beginning.
> I also wouldn't use `check_output()`: if `git` fails for whatever
reason, that shouldn't be a reason to abort doctesting.
I've made the other changes. My only question is, if `git` fails, should
we print the error message? That's what happens with the latest branch: it
gets printed but not recorded in the log. For example, if I replace
`$SAGE_ROOT/.git` with an empty directory, I get
{{{
Running doctests with ID 2014-10-20-13-02-47-ec16085e.
fatal: Not a git repository:
'/Users/palmieri/Desktop/Sage_stuff/git/sage/.git'
Doctesting entire Sage library.
}}}
Should we suppress the error message altogether, or keep it?
--
Ticket URL: <http://trac.sagemath.org/ticket/17153#comment:7>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.
