#17153: Print the git branch when doctesting
-------------------------------------+-------------------------------------
Reporter: jhpalmieri | Owner:
Type: enhancement | Status: needs_review
Priority: major | Milestone: sage-6.4
Component: doctest framework | Resolution:
Keywords: | Merged in:
Authors: John Palmieri | Reviewers: Jeroen Demeyer
Report Upstream: N/A | Work issues:
Branch: | Commit:
u/jhpalmieri/print_branch | 4b732bd6ca28105b8cd61385134825bb6c24a43c
Dependencies: | Stopgaps:
-------------------------------------+-------------------------------------
Comment (by jdemeyer):
Replying to [comment:7 jhpalmieri]:
> My only question is, if `git` fails, should we print the error message?
That's what happens with the latest branch: it gets printed but not
recorded in the log. For example, if I replace `$SAGE_ROOT/.git` with an
empty directory, I get
> {{{
> Running doctests with ID 2014-10-20-13-02-47-ec16085e.
> fatal: Not a git repository:
'/Users/palmieri/Desktop/Sage_stuff/git/sage/.git'
> Doctesting entire Sage library.
> }}}
> Should we suppress the error message altogether, or keep it?
I would leave it as it is. It's not that important anyway...
--
Ticket URL: <http://trac.sagemath.org/ticket/17153#comment:9>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.
