#17232: Remove useless "copy" arguments and normalize steiner_quadruple_system
-------------------------------------+-------------------------------------
Reporter: ncohen | Owner:
Type: enhancement | Status: needs_review
Priority: major | Milestone: sage-6.4
Component: combinatorial | Resolution:
designs | Merged in:
Keywords: | Reviewers:
Authors: Nathann Cohen | Work issues:
Report Upstream: N/A | Commit:
Branch: u/ncohen/17232 | a09f66038c02df4785213b9d40310e91ded13b62
Dependencies: | Stopgaps:
-------------------------------------+-------------------------------------
Changes (by ncohen):
* status: new => needs_review
* cc: vdelecroix, dimpase (added)
* branch: => u/ncohen/17232
* commit: => a09f66038c02df4785213b9d40310e91ded13b62
Old description:
> With this branch the following is done:
>
> 1) The "copy" boolean flag is removed from the methods of
> `IncidenceStructure` where it was useless, i.e. all except the
> constructors. This was always a "don't change unless you know what you
> do" flag, and persons who know what they do might as well access the
> internal data structure immediately, i.e. without function call.
>
> 2) The file `steiner_quadruple_systems` did not use `IncidenceStructure`
> at all, and this is now fixed. There was also a function
> `is_steiner_quadruple_system` which was a specific case of
> `IncidenceStructure.is_t_design`. Now, all those functions take
> `IncidenceStructure` as input and return `IncidenceStructure` objects.
>
> Nathann
New description:
With this branch the following is done:
1) The "copy" boolean flag is removed from the methods of
`IncidenceStructure` where it was useless, i.e. all except the
constructors. This was always a "don't change unless you know what you do"
flag, and persons who know what they do might as well access the internal
data structure immediately, i.e. without function call.
2) The file `steiner_quadruple_systems` did not use `IncidenceStructure`
at all, and this is now fixed. There was also a function
`is_steiner_quadruple_system` which was a specific case of
`IncidenceStructure.is_t_design`. Now, all those functions take
`IncidenceStructure` as input and return `IncidenceStructure` objects. In
particular:
Before
{{{
sage: designs.steiner_quadruple_system(20)
((0, 1, 2, 9),
(0, 1, 12, 19),
(0, 11, 2, 19),
...
}}}
After
{{{
sage: designs.steiner_quadruple_system(20)
Incidence structure with 20 points and 285 blocks
}}}
Nathann
--
Comment:
New commits:
||[http://git.sagemath.org/sage.git/commit/?id=a09f66038c02df4785213b9d40310e91ded13b62
a09f660]||{{{trac #17232: Remove useless "copy" arguments and normalize
steiner_quadruple_system}}}||
--
Ticket URL: <http://trac.sagemath.org/ticket/17232#comment:1>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.
