#17231: LatticePoset: join and meet of several elements
-------------------------------------+-------------------------------------
Reporter: jmantysalo | Owner:
Type: enhancement | Status: needs_review
Priority: minor | Milestone: sage-wishlist
Component: combinatorics | Resolution:
Keywords: | Merged in:
Authors: Jori Mäntysalo | Reviewers:
Report Upstream: N/A | Work issues:
Branch: | Commit:
u/jmantysalo/latticeposet__join_and_meet_of_several_elements|
8095cf3454314a8a8b0bbec84ed46139e5c9451a
Dependencies: | Stopgaps:
-------------------------------------+-------------------------------------
Comment (by jmantysalo):
Replying to [comment:4 ncohen]:
> I do not understand why you do
> {{{
> i, j = map(self._element_to_vertex, (x,y))
> return self._vertex_to_element(self._hasse_diagram._meet[i,j])
> }}}
> and not only
> {{{
> x=(x,y)
> }}}
I do not understand what you don't understand. `:=)`
I the function get an element of the lattice as an argument, say `'a'`, it
must convert it to "element" of the Hasse diagram, get meet and convert
back. Maybe instead of `map` it would be better to have just
{{{
i = self._element_to_vertex(x)
j = self._element_to_vertex(y)
}}}
Or do you mean to remove part I marked as "Handle basic case fast" to
comments?
> Short of that, you updated the docstring of "join" but did not do the
same for "meet".
True. Must correct this.
--
Ticket URL: <http://trac.sagemath.org/ticket/17231#comment:5>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.
