#16640: Graphics3d.show abuses graphics_filename
-------------------------------------+-------------------------------------
Reporter: gagern | Owner:
Type: defect | Status: needs_review
Priority: major | Milestone: sage-6.4
Component: graphics | Resolution:
Keywords: | Merged in:
Authors: Martin von Gagern | Reviewers: Jeroen Demeyer
Report Upstream: N/A | Work issues:
Branch: | Commit:
u/jdemeyer/ticket/16640 | 711127f7cf89f6e75d7f2e970c4a58ec51ec03c5
Dependencies: | Stopgaps:
-------------------------------------+-------------------------------------
Comment (by gagern):
Hi, sorry I didn't respond to the commits by Jeroen any sooner.
Replying to [comment:13 kcrisman]:
> Hi Jeroen: Your first two commits are fine,
I agree. Thanks a lot!
> (Martin, if you see this, what was your thinking on changing the doctest
mode?)
My main reason for modifying that line at all was the fact that canvas3d
only works in embedded mode, so having it available otherwise might
confuse users. My reson for including it in doctests is simply because all
the other possible viewers are active in doctest mode as well. There is a
doctest specifically for the canvas3d case, but if I restrict canvas3d to
embedded mode only, that one would fail. So staying in line with all the
other tests seemed the reasonable thing to do.
If things really are too slow, I'd change that to
{{{if viewer == 'canvas3d' and (DOCTEST_MODE or EMBEDDED_MODE):}}}
so we can have that one explicit doctest nevertheless. But first I'd like
to quantify that effect on test execution time, and right now I have a
build problem.
--
Ticket URL: <http://trac.sagemath.org/ticket/16640#comment:14>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.
