#16640: Graphics3d.show abuses graphics_filename
-------------------------------------+-------------------------------------
Reporter: gagern | Owner:
Type: defect | Status: needs_review
Priority: major | Milestone: sage-6.4
Component: graphics | Resolution:
Keywords: | Merged in:
Authors: Martin von Gagern | Reviewers: Jeroen Demeyer
Report Upstream: N/A | Work issues:
Branch: | Commit:
u/jdemeyer/ticket/16640 | bd1479d38fe1adb42755ab92499ff8c1ba35592d
Dependencies: | Stopgaps:
-------------------------------------+-------------------------------------
Comment (by kcrisman):
Here is something minor but still needing attention. The documentation
says
{{{
- ``filename`` -- string (default: a temp file); file
to save the image to
}}}
but of course this is now only going to be true in the command line.
Which probably makes sense. But this should be noted. Similarly,
{{{
# Tachyon resolution options
}}}
should probably just add a quick note that "mode defaults" also are being
set in the next few lines.
Interestingly,
{{{
# Temporary hack: encode the desired applet size in the end of
the filename:
# (This will be removed once we have dynamic resizing of
applets in the browser.)
}}}
and the following code could in principle be removed, as the update does
indeed have dynamic resizing! But I think let's leave that be for
somewhere else; I don't want to mess with the already messy naming of jmol
stuff...
Finally, I don't understand this comment - I'm sorry if I am just thinking
inside the box:
{{{
# when testing this, modify graphics_filename so that it
# returns files which don't automatically share a base
name,
# e.g.: "import random; i = random.randint(0, 10000)"
}}}
Was this just a "note to self" or do you mean that, as a tester, I should
actually change `graphics_filename` instead of letting it just keep adding
one to base names, or ... ? I figured the whole point of this change was
to test where they ''did'' share a base name, but again I may be thinking
too conventionally.
--
Ticket URL: <http://trac.sagemath.org/ticket/16640#comment:19>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.
