#7946: Fix TestSuite failures for schemes
-------------------------------------+-------------------------------------
Reporter: nthiery | Owner: AlexGhitza
Type: defect | Status: positive_review
Priority: major | Milestone: sage-6.4
Component: algebraic | Resolution:
geometry | Merged in:
Keywords: | Reviewers: Travis Scrimshaw
Authors: Peter Bruin | Work issues:
Report Upstream: N/A | Commit:
Branch: | 5fd92eed3024163fa068bea8e3644d677f151adc
u/pbruin/7946-scheme_point_improvements| Stopgaps:
Dependencies: #16158 |
-------------------------------------+-------------------------------------
Changes (by pbruin):
* status: needs_review => positive_review
Comment:
Replying to [comment:11 tscrim]:
> Replying to [comment:8 pbruin]:
> > The attached branch makes affine schemes, and points on them,
cooperate better with the category and coercion code. The `TestSuite` now
runs without failures.
>
> Is there some way you can get rid of that custom `__call__` method in
`AffineScheme`, or at least passes things up through the `Parent.__call__`
when trying to construct an element? If not, then I think we're okay
setting this to positive review as it fixes the issues as stated in the
ticket description (you can do this on my behalf).
The reason this is done via the `__call__()` method is that an affine
scheme ''S'' accepts two kinds of input; only one of them (input is a
prime ideal) constructs an element with ''S'' as its parent. In the other
case (input is a list of coordinates) the `__call__()` syntax constructs
an element of a suitable scheme homset. I don't see an easy way to avoid
a custom `__call__()` method; it may be possible (and would be nice) to
get rid of it, but it is better to do this on separate ticket. (Note also
that the `__call__()` method was already present, I just improved it as
necessary.)
> Also, I think that comment:6 (from the ''very'' limited understanding I
have of the math) is the correct way to do things. However that would be a
major overhaul to be done on a separate ticket, and perhaps the above
change to `__call__` would fit into that.
What I was talking about in that comment was mostly done on #16158 (closed
a couple of months ago). I think the remaining issue of making a category
`AffineSchemes` would probably be disjoint from getting rid of the
`__call__()` method.
I'm setting this to positive review since you gave the green light.
--
Ticket URL: <http://trac.sagemath.org/ticket/7946#comment:12>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.
