#7946: Fix TestSuite failures for schemes
-------------------------------------+-------------------------------------
Reporter: nthiery | Owner: AlexGhitza
Type: defect | Status: positive_review
Priority: major | Milestone: sage-6.4
Component: algebraic | Resolution:
geometry | Merged in:
Keywords: | Reviewers: Travis Scrimshaw
Authors: Peter Bruin | Work issues:
Report Upstream: N/A | Commit:
Branch: | 5fd92eed3024163fa068bea8e3644d677f151adc
u/pbruin/7946-scheme_point_improvements| Stopgaps:
Dependencies: #16158 |
-------------------------------------+-------------------------------------
Comment (by tscrim):
> The reason this is done via the `__call__()` method is that an affine
scheme ''S'' accepts two kinds of input; only one of them (input is a
prime ideal) constructs an element with ''S'' as its parent. In the other
case (input is a list of coordinates) the `__call__()` syntax constructs
an element of a suitable scheme homset. I don't see an easy way to avoid
a custom `__call__()` method; it may be possible (and would be nice) to
get rid of it, but it is better to do this on separate ticket. (Note also
that the `__call__()` method was already present, I just improved it as
necessary.)
That's what I was thinking from a quick look through. Anyways, for later.
> What I was talking about in that comment was mostly done on #16158
(closed a couple of months ago). I think the remaining issue of making a
category `AffineSchemes` would probably be disjoint from getting rid of
the `__call__()` method.
I knew the last one was done, but forgot that it moved the functionality.
Unfortunately I think you're right, but we can at least do a followup to
create the category of `AffineSchemes`.
> I'm setting this to positive review since you gave the green light.
Thanks.
--
Ticket URL: <http://trac.sagemath.org/ticket/7946#comment:13>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.
