#5852: [with patch, positive review] the detection of SAGE_ROOT in 
$SAGE_ROOT/sage
script should expand symlinks recursively (fix this on systems that support
readlink -f)
----------------------+-----------------------------------------------------
 Reporter:  tornaria  |        Owner:  tornaria
     Type:  defect    |       Status:  closed  
 Priority:  major     |    Milestone:  sage-4.0
Component:  misc      |   Resolution:  fixed   
 Keywords:            |     Reviewer:          
   Author:            |       Merged:          
----------------------+-----------------------------------------------------

Comment(by was):

 Question.  Does
 {{{
 readlink -n sage
 }}}
 work on any platform?!  It gives an error on *both* OS X and Linux.  Why
 is it even there?!
 {{{
 OS X
 ub243101:s wstein$ readlink -n sage
 ub243101:s wstein$ echo $?
 1

 Linux:
 wst...@boxen:~/sage$ readlink -n sage
 wst...@boxen:~/sage$ echo $?
 1
 }}}

 I wonder who wrote this weird SAGE_ROOT code in the first place?  I wrote
 something a long time ago, but it bears no resemblance to the current
 code.


 By the way, I've had reports of major failures caused by using {{{readlink
 -nf}}} by one user who has a symlink + nfs mount setup.  Their problems
 are solved by deleting the {{{readlink -nf}}} line.   Why don't we use
 realpath first and only if that doesn't work use something else?  It seems
 like realpath is the right choice, since it's supposed to " converts each
 filename argument to an absolute pathname, which has no components that
 are symbolic links or the special
        .  or ..  directory entries...  Please note that mostly the same
 functionality is provided by the ‘-f’ option."

 There is no realpath on OS X, but that is ok since readlink doesn't work
 ever on OS X anyways, so no loss.

  -- William

-- 
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/5852#comment:8>
Sage <http://sagemath.org/>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica, 
and MATLAB

--~--~---------~--~----~------------~-------~--~----~
You received this message because you are subscribed to the Google Groups 
"sage-trac" group.
To post to this group, send email to [email protected]
To unsubscribe from this group, send email to 
[email protected]
For more options, visit this group at 
http://groups.google.com/group/sage-trac?hl=en
-~----------~----~----~----~------~----~------~--~---

Reply via email to