#5852: [with patch, positive review] the detection of SAGE_ROOT in
$SAGE_ROOT/sage
script should expand symlinks recursively (fix this on systems that support
readlink -f)
----------------------+-----------------------------------------------------
Reporter: tornaria | Owner: tornaria
Type: defect | Status: closed
Priority: major | Milestone: sage-4.0
Component: misc | Resolution: fixed
Keywords: | Reviewer:
Author: | Merged:
----------------------+-----------------------------------------------------
Comment(by was):
The problem with this patch isn't that it is "wrong" (which is what you're
arguing with me about above). It is that it seriously breaks Sage, hence
it must be reverted or the problem it causes must be fixed. I had a look,
and the problem is here in local/bin/sage-doctest:
{{{
library_code = True
ext = os.path.splitext(argv[1])[1]
if ext in ['.spyx', '.sage'] or \
not (SAGE_ROOT.strip('/') + '/devel' in
os.path.abspath(argv[1])):
library_code = False
}}}
The problem is that the library_code variable is being set to False for
all the code that *is* in the library. It is being set to false because
if one does
{{{
sage -t "/home/wstein/sage-build/sage-nnn/..."
}}}
then argv[1] is not first canonicalized, which messes everything up
completely.
So for this ticket to be in (which I agree with at some point), one needs
to factor out this path caonicalization, and make sure it is applied
everywhere (e.g,. in sage-doctest). There could be many other places
where subtle problems arise -- I don't know.
For now, this needs to be reverted.
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/5852#comment:12>
Sage <http://sagemath.org/>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--~--~---------~--~----~------------~-------~--~----~
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected]
To unsubscribe from this group, send email to
[email protected]
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en
-~----------~----~----~----~------~----~------~--~---
