#15948: marked Dynkin diagrams
-------------------------------------+-------------------------------------
       Reporter:  vittucek           |        Owner:
           Type:  enhancement        |       Status:  positive_review
       Priority:  major              |    Milestone:  sage-6.4
      Component:  combinatorics      |   Resolution:
       Keywords:                     |    Merged in:
        Authors:  Vít Tuček, Travis  |    Reviewers:  Travis Scrimshaw, Vít
  Scrimshaw                          |  Tuček
Report Upstream:  N/A                |  Work issues:
         Branch:                     |       Commit:
  public/combinat/root_systems/marked_types-15948|  
bf5e867266ab8ddb17e0be8c6e1cf619b266b10e
   Dependencies:  #16380             |     Stopgaps:
-------------------------------------+-------------------------------------
Changes (by vittucek):

 * status:  needs_review => positive_review


Comment:

 Just to be sure. I've pulled this branch again and recompiled. The same
 problem. Here are some of the errors:


 {{{
 sage -t src/sage/combinat/root_system/root_lattice_realizations.py
 **********************************************************************
 File "src/sage/combinat/root_system/root_lattice_realizations.py", line
 881, in
 
sage.combinat.root_system.root_lattice_realizations.RootLatticeRealizations.ParentMethods.positive_roots_by_height
 Failed example:
     L.positive_roots_by_height()
 Expected:
     [alpha[2], alpha[1], alpha[1] + alpha[2], 2*alpha[1] + alpha[2]]
 Got:
     [alpha[1], alpha[2], alpha[1] + alpha[2], 2*alpha[1] + alpha[2]]
 **********************************************************************
 File "src/sage/combinat/root_system/root_lattice_realizations.py", line
 883, in
 
sage.combinat.root_system.root_lattice_realizations.RootLatticeRealizations.ParentMethods.positive_roots_by_height
 Failed example:
     L.positive_roots_by_height(increasing = False)
 Expected:
     [2*alpha[1] + alpha[2], alpha[1] + alpha[2], alpha[2], alpha[1]]
 Got:
     [2*alpha[1] + alpha[2], alpha[1] + alpha[2], alpha[1], alpha[2]]
 **********************************************************************
 File "src/sage/combinat/root_system/root_lattice_realizations.py", line
 2237, in
 
sage.combinat.root_system.root_lattice_realizations.RootLatticeRealizations.ParentMethods.plot_roots
 Failed example:
     RootSystem(["B",3]).ambient_space().plot_roots()
 Expected:
     Graphics3d Object
 Got:
     <BLANKLINE>

 }}}
 and many more of the same type.

 {{{
 10 items had failures:
    1 of   8 in
 
sage.combinat.root_system.root_lattice_realizations.RootLatticeRealizations.ParentMethods.plot_alcove_walk
    1 of   8 in
 
sage.combinat.root_system.root_lattice_realizations.RootLatticeRealizations.ParentMethods.plot_alcoves
    1 of   4 in
 
sage.combinat.root_system.root_lattice_realizations.RootLatticeRealizations.ParentMethods.plot_bounding_box
    1 of   3 in
 
sage.combinat.root_system.root_lattice_realizations.RootLatticeRealizations.ParentMethods.plot_coroots
    5 of  10 in
 
sage.combinat.root_system.root_lattice_realizations.RootLatticeRealizations.ParentMethods.plot_fundamental_chamber
    1 of   4 in
 
sage.combinat.root_system.root_lattice_realizations.RootLatticeRealizations.ParentMethods.plot_fundamental_weights
    5 of   8 in
 
sage.combinat.root_system.root_lattice_realizations.RootLatticeRealizations.ParentMethods.plot_hedron
    8 of  14 in
 
sage.combinat.root_system.root_lattice_realizations.RootLatticeRealizations.ParentMethods.plot_reflection_hyperplanes
    2 of   8 in
 
sage.combinat.root_system.root_lattice_realizations.RootLatticeRealizations.ParentMethods.plot_roots
    2 of   6 in
 
sage.combinat.root_system.root_lattice_realizations.RootLatticeRealizations.ParentMethods.positive_roots_by_height
     [557 tests, 27 failures, 16.82 s]
 }}}

 At last I've tried to run all single tests via bash (i.e. something like
 {{{for i in src/.../root_system/*; do ./sage -t $i; done}}}) and the
 results were again fine. This leads me to believe that the problem lies
 within SMC. I am notifying William Stein about this problem and setting
 positive review on this ticket.

--
Ticket URL: <http://trac.sagemath.org/ticket/15948#comment:45>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica, 
and MATLAB

-- 
You received this message because you are subscribed to the Google Groups 
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.

Reply via email to