#6045: [with patch, needs work (a little)] Computation of Heegner points
---------------------------+------------------------------------------------
Reporter: robertwb | Owner: was
Type: defect | Status: new
Priority: major | Milestone: sage-4.1
Component: number theory | Keywords:
Reviewer: | Author:
Merged: |
---------------------------+------------------------------------------------
Comment(by cremona):
Final review: Sorry about the first one, I meant to say that in the
comment now in line 7026 "the the" should be "the".
One small thing I found:
{{{
sage: E=EllipticCurve([1,0,0,-1,0])
sage: [E.heegner_point(D) for D in E.heegner_discriminants_list(3)]
...
/home/jec/sage-4.1.alpha3/local/lib/python2.6/site-
packages/sage/schemes/elliptic_curves/ell_rational_field.pyc in
_heegner_best_tau(self, D, prec)
5353 N = self.conductor()
5354 b = ZZ(Integers(4*N)(D).sqrt(extend=False) % (2*N))
-> 5355 return (-b + D.sqrt(prec=prec)) / (2*N)
5356
5357 def heegner_point(self, D, prec=None, max_prec=2000):
AttributeError: 'int' object has no attribute 'sqrt'
}}}
The function _heegner_best_tau() needs to coerce D into ZZ before calling
D.sqrt(). I think some other functions might do well to make D into a ZZ
as well.
Otherwise I am happy.
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/6045#comment:21>
Sage <http://sagemath.org/>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--~--~---------~--~----~------------~-------~--~----~
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected]
To unsubscribe from this group, send email to
[email protected]
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en
-~----------~----~----~----~------~----~------~--~---
