#5098: [with patch, with review, needs work] Pollard rho algorithm for generic
discrete logarithm
-------------------------+--------------------------------------------------
Reporter: ylchapuy | Owner: tbd
Type: enhancement | Status: new
Priority: minor | Milestone: sage-4.1
Component: algebra | Keywords:
Reviewer: | Author:
Merged: |
-------------------------+--------------------------------------------------
Comment(by cremona):
This looks ok to me. It applies fine to 4.1.alpha3 and tests pass. It
might be better to call the function discrete_log_rho instead of
pollard_rho_log as that would make it easier to find via tab completion on
discrete_*.
There should also be examples (doctests) to illustrate the use of the
parameters partition_size, memory_size, hash_function, check_prime. For
example, one where using a non-default value gives better (i.e. faster)
results. If it is not practical to put those into doctests (for example,
if the improvement is only noticeable with very large examples), tehre
should still be small examples to illustrate these parameters, with a
comment about them being too small to notice, just to show how they are
used.
And the technical parameters partition_size, memory_size should be listed
in the INPUT block rather than in a separate note.
I have left this as "needs work" but those things are very small and a
positive review is not far away!
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/5098#comment:30>
Sage <http://sagemath.org/>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--~--~---------~--~----~------------~-------~--~----~
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected]
To unsubscribe from this group, send email to
[email protected]
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en
-~----------~----~----~----~------~----~------~--~---
