#6362: [with spkg, positive review] Singular and GCC 4.4
------------------------+---------------------------------------------------
Reporter: aginiewicz | Owner: tbd
Type: defect | Status: new
Priority: blocker | Milestone: sage-4.1
Component: algebra | Keywords:
Reviewer: | Author:
Merged: |
------------------------+---------------------------------------------------
Old description:
> singular is last package that don't compile with latest GCC 4.4 for me,
> it's because of use of strchr function, see GCC 4.4
> [http://gcc.gnu.org/gcc-4.4/porting_to.html porting guide] part "Strict
> null-terminated sequence utilities" - there is used
>
> char* strchr(const char*, int)
>
> that silently cast-away const, simple explicit cast to char* removes the
> error during compilation for me so it's trivial to fix. The strchr
> function in this form is used twice.
>
> I made spkg that's fixed, wasn't creating patches/spkg for Sage for some
> time so I ask for strict review even if it's trivial fix :) I tried to
> remember about everything with spkg creation but something could still
> slip. There is spkg:
> ~~[http://giniu.ravenlord.ws/singular-3-1-0-2-20090620.spkg]~~.
>
> Update:
>
> spkg merged with Martins version:
> http://giniu.ravenlord.ws/singular-3-1-0-4-20090620.spkg
New description:
singular is last package that don't compile with latest GCC 4.4 for me,
it's because of use of strchr function, see GCC 4.4
[http://gcc.gnu.org/gcc-4.4/porting_to.html porting guide] part "Strict
null-terminated sequence utilities" - there is used
char* strchr(const char*, int)
that silently cast-away const, simple explicit cast to char* removes the
error during compilation for me so it's trivial to fix. The strchr
function in this form is used twice.
I made spkg that's fixed, wasn't creating patches/spkg for Sage for some
time so I ask for strict review even if it's trivial fix :) I tried to
remember about everything with spkg creation but something could still
slip. There is spkg:
~~[http://giniu.ravenlord.ws/singular-3-1-0-2-20090620.spkg]~~.
Update:
spkg merged with Martins version:
~~[http://giniu.ravenlord.ws/singular-3-1-0-4-20090620.spkg]~~, and the
fixed one: http://giniu.ravenlord.ws/singular-3-1-0-4-20090703.spkg
--
Comment(by aginiewicz):
Fixed description in ticked to make sure which one is latest, as with
Johns review link to spkg got reverted to not latest version.
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/6362#comment:20>
Sage <http://sagemath.org/>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--~--~---------~--~----~------------~-------~--~----~
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected]
To unsubscribe from this group, send email to
[email protected]
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en
-~----------~----~----~----~------~----~------~--~---
