#17030: Knot Theory as a part of GSoC 2014.
-------------------------------------+-------------------------------------
Reporter: amitjamadagni | Owner: amitjamadagni
Type: enhancement | Status: needs_review
Priority: major | Milestone: sage-6.4
Component: algebraic | Resolution:
topology | Merged in:
Keywords: | Reviewers:
Authors: Amit Jamadagni, | Work issues:
Miguel Marco | Commit:
Report Upstream: N/A | 37bd26ba2e6ccd45e886fd7fdcbcdfa4d0ba0d03
Branch: | Stopgaps:
u/mmarco/ticket/17030 |
Dependencies: |
-------------------------------------+-------------------------------------
Comment (by vdelecroix):
I would be happy to participate in the review. But first, you have to read
my two cents about git history. I think that the git history must be
helpful to newcomers and not for archaeologists (for them, we have trac
and sage-devel. Moreover, they do not necessarily want to know that in the
first n commits you were just trying to understand how to use git).
More precisely:
- keep the history simple
- always have the following sentence in mind: "what is the most helpful
for the reviewer?"
More concretely
- merge as less as possible
- if you modify a lot on an already existing file, try to have one commit
that deletes and an other one that adds
- if you are only providing new functionalities in independent file, try
to minimize the number of commits (or at least make them coherent for the
reader)
Git history could be really helpful to reviewer. For example, if you
simply move a file, the commit will only be "mv old_file -> new_file".
Hence, as a reviewer, I know that there is nothing to check in that file.
Vincent
--
Ticket URL: <http://trac.sagemath.org/ticket/17030#comment:73>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.
