#16629: Improve sage-fix-pkg-checksums
-------------------------------------+-------------------------------------
Reporter: charpent | Owner:
Type: defect | Status: needs_review
Priority: minor | Milestone: sage-6.4
Component: build | Resolution:
Keywords: | Merged in:
Authors: Emmanuel | Reviewers: Jeroen Demeyer
Charpentier, Volker Braun (with | Work issues:
input from J. H. Palmieri) | Commit:
Report Upstream: N/A | a0469055a4f293df53e6f6ae42ac9dc0e761f7c8
Branch: | Stopgaps:
u/charpent/sage_fix_pkg_checksums_munches_build_pkgs__packagename__checksums|
Dependencies: |
-------------------------------------+-------------------------------------
Changes (by charpent):
* status: needs_work => needs_review
Old description:
New description:
The current version of sage-fix-pkg-checksums incorrectly sets the package
version to the *litteral* "VERSION" in checksums.ini, which is confusing
and not helpful. Curiously, this is still (sort of) functional.
This patch correcly computes the version string and puts it at the right
place in checksums.ini.
--
Comment:
Replying to [comment:26 jdemeyer]:
> Authors: please describe what this patch is supposed to do, because the
previous description was wrong (`package-version.txt` isn't changed by
`sage-fix-pkg-checksums`) and confusing! It's easier to review when I
know what this patch is supposed to achieve.
Done
> And fix the indentation please: no TABS, use indents of 4 spaces
Also done. Although I wonder why this recommendation, which is sensible
for python (and sage) programs, should apply to shell scripts, which are a
horse of a totally different color...
> And I would like to add an additional change:
> {{{
> upstream_pkg_name=${tarball%-*}
> }}}
> should become
> {{{
> upstream_pkg_name=${tarball%%-*}
> }}}
> to allow upstream versions with dashes (package-abc-1 should have
package name "package" and version "abc-1").
Also done (although I'm not sure of the pertinence...).
HTH,
--
Ticket URL: <http://trac.sagemath.org/ticket/16629#comment:28>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.
