#15820: Implement sequences of bounded integers
-------------------------------------+-------------------------------------
Reporter: SimonKing | Owner:
Type: enhancement | Status: needs_work
Priority: major | Milestone: sage-6.4
Component: algebra | Resolution:
Keywords: sequence bounded | Merged in:
integer | Reviewers: Jeroen Demeyer, Simon
Authors: Simon King, | King
Jeroen Demeyer | Work issues: interrupt handling
Report Upstream: N/A | Commit:
Branch: | 8db9f6542a54ead67c1df3d069103b620e85eea6
u/jdemeyer/ticket/15820 | Stopgaps:
Dependencies: #17195, #17196 |
-------------------------------------+-------------------------------------
Comment (by SimonKing):
Dear Jeroen,
thank you for reviewing!
Replying to [comment:350 jdemeyer]:
> We are still missing `sig_*` functions to allow interrupts. But I prefer
for you to review my changes before adding those.
- You changed the location of the (old) function `bitset_fix`. Why? Won't
that increase the likelihood of a merge conflict?
- When reading the function name `biseq_reverse_contains`, I'd expect that
it either checks for containment of a reverse subsequence, or it checks
for containment of a subsequence starting at the end of the supersequence.
Both is not the case. What this function determines is an overlap of the
end of first and the beginning of the second argument. That said, I don't
think the new function name is worse than the old.
The other changes seem at least reasonable, some are needed. Thanks for
spotting it.
In any case, there will be a merge conflict with the next follow-up
ticket. But I guess it can hardly be avoided. I think we can now take care
of signal handling.
--
Ticket URL: <http://trac.sagemath.org/ticket/15820#comment:351>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.
