#14239: symbolic radical expression for algebraic number
-------------------------------------+-------------------------------------
Reporter: gagern | Owner: davidloeffler
Type: enhancement | Status: needs_work
Priority: major | Milestone: sage-6.4
Component: number fields | Resolution:
Keywords: | Merged in:
Authors: Martin von Gagern | Reviewers: Marc Mezzarobba,
Report Upstream: N/A | Jeroen Demeyer
Branch: | Work issues:
u/jdemeyer/ticket/14239 | Commit:
Dependencies: #17495 | 01b7e9e4aaa15a34d1d19788c36f47df1741bfe6
| Stopgaps:
-------------------------------------+-------------------------------------
Comment (by gagern):
I don't know about the internals of `refine_embedding`, but 01b7e9e looks
good to me at first glance. The fact that id adds a dependency feels bad,
though, since that would mean further delay on this ticket here. Of
course, failing doctests make development tricky here.
In 06da2a3 you drop the caching of the symbolic conversion of the
generator, which might be bad for performance. What is your rationale
behind this? And what is your rationale for moving the application of
`self.polynomial()` to `QQbar` instead of `SR`? On the whole, I can see
your motivation for wanting further simplification there, but I don't see
this related to this ticket here. This ticket here is in my opinion about
a new method for algebraic numbers, without introducing duplicate code.
That doesn't need your simplifications. Can we keep separate concerns
separate? If you review my code, I'll be happy to review any
simplifications you build on that in a separate ticket.
--
Ticket URL: <http://trac.sagemath.org/ticket/14239#comment:59>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.
