#17489: remove redundant factorial() from rings/arith.py
-------------------------------------+-------------------------------------
Reporter: rws | Owner:
Type: defect | Status: needs_review
Priority: major | Milestone: sage-6.5
Component: symbolics | Resolution:
Keywords: | Merged in:
Authors: Ralf Stephan | Reviewers: Jeroen Demeyer
Report Upstream: N/A | Work issues:
Branch: | Commit:
u/rws/remove_redundant_factorial___from_rings_arith_py|
3b54c755b2da09d40872276d0d95d941ddcdea66
Dependencies: | Stopgaps:
-------------------------------------+-------------------------------------
Changes (by rws):
* status: needs_work => needs_review
Comment:
Replying to [comment:11 jdemeyer]:
> Replying to [comment:10 rws]:
> > Replying to [comment:9 jdemeyer]:
> > And remove the doctest?
> No, add the deprecation message in the doctest.
Not possible because only the first message is printed. I removed the
doctests.
> Also, instead of ''removing'' the factorial function from
`rings/arith.py`, it should be deprecated (or perhaps a lazy import with
deprecation).
Any import of `factorial` is overwritten by
`sage.functions.other.factorial`
--
Ticket URL: <http://trac.sagemath.org/ticket/17489#comment:15>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.
