#17534: The reviewer's checklist
-------------------------+-------------------------------------------------
Reporter: | Owner:
ncohen | Status: needs_review
Type: | Milestone: sage-6.5
enhancement | Resolution:
Priority: major | Merged in:
Component: | Reviewers: Jeroen Demeyer, Karl-Dieter
documentation | Crisman, Martin Rubey
Keywords: | Work issues:
Authors: | Commit:
Nathann Cohen | 375d087b7820996f237ff97d49b971e1e921194a
Report Upstream: N/A | Stopgaps:
Branch: |
public/17534 |
Dependencies: |
-------------------------+-------------------------------------------------
Comment (by ncohen):
Yo !
> Unfortunately I won't have time for that for a number of days.
Well, I fixed your comments in a new commit, in the hope that you would
give this ticket a positive review during your next 10-minutes break `:-P`
> All I mean is "Maybe the section 'closing tickets' could become
'reviewing and closing tickets' " and then just add a paragraph saying
something like "Tickets can be closed when they have positive review or
for other reasons. To learn how to review, please see <the following
section>." Then the current text follows.
Done.
> But nonetheless "status" ''is'' a field, so it should be (however
briefly) mentioned!
Done.
> That is not one of my primary goals in this particular document, which
is different from the intro to the developer guide.
Well, just in case some guy who read the intro would end up on this page,
I would also like to make it enjoyable to some extent. I am trying to give
everybody the possibility to follow links if they are interested, and to
continue with the main document if they are not.
> I am talking not about how to ''write'' doctests, but how to ''test and
review''. In which case we should mention people trying wacky stuff or
just lots of ordinary stuff,
Hmmmmm... I would say that a clear page on the different types of
doctests, what they check and how they do it would also be of some help to
reviewers. Knowing what people usually test in doctests would tell them
what they should pay attention to.
> but I certainly am not suggesting that every such thing should be
included as a reviewer patch doctest.
Oh. Well, I am glad to read that as I had understood it differently. Glad
to know that I don't have to write all that right now in order for this
patch to pass `:-PPPPP`
> As to the other comments, probably I would write it differently but this
is also okay. But I won't be able to finish review until a bit from now,
as I said.
Okay. Well, I will push the commit in a second, then it's your turn.
Nathann
--
Ticket URL: <http://trac.sagemath.org/ticket/17534#comment:16>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.
