#17570: ToricRationalDivisorClass: Integer/Rational mixed up
-------------------------------------+-------------------------------------
Reporter: jdemeyer | Owner:
Type: defect | Status: needs_work
Priority: major | Milestone: sage-6.5
Component: geometry | Resolution:
Keywords: | Merged in:
Authors: Jeroen Demeyer | Reviewers:
Report Upstream: N/A | Work issues:
Branch: | Commit:
u/jdemeyer/ticket/17570 | b2c68ca56a6235b049c260c0cf181a252935037c
Dependencies: | Stopgaps:
-------------------------------------+-------------------------------------
Changes (by novoselt):
* status: needs_review => needs_work
Comment:
Replying to [comment:4 jdemeyer]:
> This branch passes all doctests, however I admit that I do not
understand what this code is doing and whether my fix does ''The Right
Thing''.
It is most definitely not the right thing to do in the cone module - a
lattice is a free module over integers and not rationals! (On the other
hand there is nothing wrong with a vector over rationals related to a cone
defined over integers.) I can try to figure out what is the right thing to
do here, but not this minute.
--
Ticket URL: <http://trac.sagemath.org/ticket/17570#comment:5>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.
