#6525: [with patch, needs work] Enabling some GraphLatex options that were hard
coded.
--------------------------+-------------------------------------------------
Reporter: fidelbarrera | Owner: rlm
Type: enhancement | Status: new
Priority: minor | Milestone: sage-feature
Component: graph theory | Keywords: latex, graph, graphlatex
Reviewer: | Author: Fidel Barrera-Cruz
Merged: |
--------------------------+-------------------------------------------------
Comment(by rbeezer):
1. Spelling: "whether" (not "wether") in a couple places.
2. In the docstrings, you don't need blank lines to separate list items.
Too many blank lines and the text versions from tab completion get spread-
out. But a few (like at the end of long sub-lists) I think are helpful.
3. Should probably raise a {{{ValueError}}} when input is bad, such as
{{{
if not units in ['in','mm','cm','pt', 'em', 'ex']:
print 'Unknown units: %s. Must be one of: in, mm, cm, pt, em, ex'%
units
return
}}}
becomes (note lower case, no periods)
{{{
if not units in ['in','mm','cm','pt', 'em', 'ex']:
raise ValueError('unknown units: %s, must be one of: in, mm, cm, pt,
em, ex'% units)
}}}
Might want to test some of these error messages with doctests.
4. Would it make sense to trap errors like the one above when it is set
(ie in {{{GraphLatex.set_option()}}}? It is possible some errors won't be
apparent until it is time to plot, but the one above could be caught when
the option is set. But maybe it is best to put all the error-checking in
the routine building the latex code? Probably so, especially if there is
ever support for some other latex graph drawing package.
5. About 11 doctests fail for me - they all look trivial - just update
the options produced since there are now default values for several new
options. All the latex code seems alright, as you would expect/hope.
6. Once there are a few more options available, I'll expand the
documentation at the top of the module to advertise the possibilities.
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/6525#comment:2>
Sage <http://sagemath.org/>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--~--~---------~--~----~------------~-------~--~----~
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected]
To unsubscribe from this group, send email to
[email protected]
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en
-~----------~----~----~----~------~----~------~--~---
