#17582: Bandwidth of a graph
-------------------------+-------------------------------------------------
Reporter: | Owner:
ncohen | Status: needs_review
Type: | Milestone: sage-6.5
enhancement | Resolution:
Priority: major | Merged in:
Component: graph | Reviewers: David Coudert
theory | Work issues:
Keywords: | Commit:
Authors: | 49eac6fa5956bd46be27182b5eae887d9632e450
Nathann Cohen | Stopgaps:
Report Upstream: N/A |
Branch: |
public/17582 |
Dependencies: |
-------------------------+-------------------------------------------------
Changes (by dcoudert):
* reviewer: => David Coudert
Comment:
This is much better now. I have some more comments:
- This method is for undirected and unweighted graphs. You could mention
it somewhere and either test input at the beginning of the method, or by
default consider the underlying undirected graph
- Why are you always returning the adjacency matrix? this could be an
optional parameter. In fact, you could have a small method that given a
graph and an ordering returns the adjacency matrix to avoid code
duplication. Such method could be useful for graphs in general.
- You never use types {{{uint16_t}}} and {{{uint64_t}}}
Otherwise, the method works very well, passes all tests, and the html doc
looks good to me.
--
Ticket URL: <http://trac.sagemath.org/ticket/17582#comment:14>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.
