#17582: Bandwidth of a graph
-------------------------+-------------------------------------------------
       Reporter:         |        Owner:
  ncohen                 |       Status:  needs_review
           Type:         |    Milestone:  sage-6.5
  enhancement            |   Resolution:
       Priority:  major  |    Merged in:
      Component:  graph  |    Reviewers:  David Coudert
  theory                 |  Work issues:
       Keywords:         |       Commit:
        Authors:         |  49eac6fa5956bd46be27182b5eae887d9632e450
  Nathann Cohen          |     Stopgaps:
Report Upstream:  N/A    |
         Branch:         |
  public/17582           |
   Dependencies:         |
-------------------------+-------------------------------------------------

Comment (by ncohen):

 Yo !

 > - This method is for undirected and unweighted graphs. You could mention
 it somewhere and either test input at the beginning of the method, or by
 default consider the underlying undirected graph

 I added tests and exceptions, as well as changed the document's title.

 > - Why are you always returning the adjacency matrix? this could be an
 optional parameter. In fact, you could have a small method that given a
 graph and an ordering returns the adjacency matrix to avoid code
 duplication. Such method could be useful for graphs in general.

 I added a 'vertices' argument to `adjacency_matrix`.

 > - You never use types {{{uint16_t}}} and {{{uint64_t}}}

 I made `index_t` be equal to `uint16_t` (no problem unless you want the
 bandwidth of a graph with n>65536) and removed the other imports.

 Nathann

--
Ticket URL: <http://trac.sagemath.org/ticket/17582#comment:15>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica, 
and MATLAB

-- 
You received this message because you are subscribed to the Google Groups 
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.

Reply via email to