#17581: resolvable BIBD
-------------------------------------+-------------------------------------
       Reporter:  ncohen             |        Owner:
           Type:  enhancement        |       Status:  needs_review
       Priority:  major              |    Milestone:  sage-6.5
      Component:  combinatorial      |   Resolution:
  designs                            |    Merged in:
       Keywords:                     |    Reviewers:
        Authors:  Nathann Cohen      |  Work issues:
Report Upstream:  N/A                |       Commit:
         Branch:  public/17581       |  1235bad6ae59f20d6ecb160c2126a9c6b134d7bb
   Dependencies:                     |     Stopgaps:
-------------------------------------+-------------------------------------

Comment (by vdelecroix):

 Hello,

 See my commit at `u/vdelecroix/17581`.

 1) Why not return an object with type `BalancedIncompleteBlockDesign`.
 That way you can add to the examples `.is_resolvable()`. (moreover,
 contrarily to the others `v_4_1_rbibd` does!?)

 2) The lines
 {{{
 bla.extend([a**(i+j0),a**(i+j1),a**(i+j2)] for i in a_big_list])
 }}}
 are ugly... I changed a bit one of them but I am still not happy to have a
 quadratic complexity when linear is doable.

 3) I used `discrete_log` where you did a `while` loop... should be faster.

 Vincent

--
Ticket URL: <http://trac.sagemath.org/ticket/17581#comment:8>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica, 
and MATLAB

-- 
You received this message because you are subscribed to the Google Groups 
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.

Reply via email to