#17612: A GroupDivisibleDesign module with a couple of constructions
-------------------------------------+-------------------------------------
       Reporter:  ncohen             |        Owner:
           Type:  enhancement        |       Status:  needs_info
       Priority:  major              |    Milestone:  sage-6.5
      Component:  combinatorial      |   Resolution:
  designs                            |    Merged in:
       Keywords:                     |    Reviewers:
        Authors:  Nathann Cohen      |  Work issues:
Report Upstream:  N/A                |       Commit:
         Branch:  public/17612       |  2401c406c149e45e6b9700c6d69fe9abf710fc22
   Dependencies:                     |     Stopgaps:
-------------------------------------+-------------------------------------

Comment (by ncohen):

 > 1) A small commit for typos in the doc.

 What's wrong with `k_k`, really ? `:-PPPP`

 > 2) `GDD(kn,{k},{n}) = TD(k,n)`, doesn't it? But `transversal_design` is
 not called in `group_divisible_design`. Is there a reason?

 Oh, true. Well, I did not need it here. But of course we can add it.
 Actually, it probably does not make much sense to have GDD ask the BIBD
 constructor, as those BIBD also yield OA. And I don't think that there is
 any OA that is built through a BIBD.

 It's up to you, we can do it now or later. I don't mind either, it all
 works.

 The reason why I wrote the GDD constructor like that is that I need those
 constructions for the KTS.

 Actually, I'm more for getting this inside first, this way I can write the
 end of the KTS code tomorrow. And perhaps another code afterward to change
 that. Then again it is all correct.

 Nathann

 P.S.: We do what you prefer, set it to positive review depending on that,
 your commit is fine.

--
Ticket URL: <http://trac.sagemath.org/ticket/17612#comment:8>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica, 
and MATLAB

-- 
You received this message because you are subscribed to the Google Groups 
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.

Reply via email to