#17618: Update matplotlib so that plot_directive is less broken
-------------------------------------+-------------------------------------
Reporter: tmonteil | Owner:
Type: enhancement | Status: new
Priority: major | Milestone: sage-6.5
Component: packages: | Resolution:
standard | Merged in:
Keywords: | Reviewers:
Authors: Thierry Monteil | Work issues:
Report Upstream: N/A | Commit:
Branch: | 065dc779e98d32ec5b081680db5356df98f15ff2
u/tmonteil/MPL-1.4 | Stopgaps:
Dependencies: |
-------------------------------------+-------------------------------------
Comment (by tmonteil):
Replying to [comment:34 fbissey]:
> I don't think the stuff with drop_list is spurious. The point is to
eliminate double entries. Indices are added to drop_list if the
corresponding point is identical to a previous one. The code you quote
builds a new set of x, y and z where each set of point is unique.
The problem is that, if `drop_list` is not empty, then at the first line,
the list `x` is shortened (duplicates are removed), but then only a prefix
of the lists `y` and `z` is dealt with (since `len(x)` decreased at the
first line).
> On the other code that code in the generation of drop_list is a bit
gauche
> {{{
> if z[i] != z[j]:
> .....
> elif z[i] == z[j]:
> drop_list.append(j)
> }}}
> Like there was a third case? the elif could be replaced by else in my
opinion.
Indeed, it would save a useless computation to just write `else`.
--
Ticket URL: <http://trac.sagemath.org/ticket/17618#comment:35>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.
