#17587: ToricLattice: fix use of span() and span_of_basis()
-------------------------------------+-------------------------------------
       Reporter:  jdemeyer           |        Owner:
           Type:  defect             |       Status:  positive_review
       Priority:  major              |    Milestone:  sage-6.5
      Component:  geometry           |   Resolution:
       Keywords:                     |    Merged in:
        Authors:                     |    Reviewers:  Jeroen Demeyer
Report Upstream:  N/A                |  Work issues:
         Branch:                     |       Commit:
  u/novoselt/ticket/17587            |  d941a1762c4cfd4da9d186992d19a80e572b6c4d
   Dependencies:                     |     Stopgaps:
-------------------------------------+-------------------------------------

Comment (by novoselt):

 What exactly is the problem? I see two:
  1. `N.span` works at all for elements that do not generate a submodule of
 `N`.
  2. `N.span` for a toric lattice returns a non-toric thing.
 But 1 is the way Sage works, so if it is changed it is better be changed
 everywhere and it will break a lot of user code too. As for 2 - writing
 custom classes for `N \otimes QQ` and its submodule would be useful, but
 is not the top priority for me personally and we managed to go a long way
 in toric stuff without implementing it...

--
Ticket URL: <http://trac.sagemath.org/ticket/17587#comment:26>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica, 
and MATLAB

-- 
You received this message because you are subscribed to the Google Groups 
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.

Reply via email to