#17556: Move simplify_log() from simplify_full() to simplify_real()
-------------------------------------+-------------------------------------
       Reporter:  mjo                |        Owner:
           Type:  enhancement        |       Status:  needs_work
       Priority:  major              |    Milestone:  sage-6.5
      Component:  symbolics          |   Resolution:
       Keywords:                     |    Merged in:
        Authors:  Michael Orlitzky   |    Reviewers:  Ralf Stephan
Report Upstream:  N/A                |  Work issues:
         Branch:                     |       Commit:
  u/mjo/ticket/17556                 |  044db1d2b7bc4e914e92ed7aa87629cbe958bc52
   Dependencies:                     |     Stopgaps:
-------------------------------------+-------------------------------------

Comment (by mjo):

 I'm going to need some help from a native speaker to fix that. The context
 of that sentence is discussing the `simplify_full()` method:

 {{{
 Falls wir alle Terme so weit wie möglich vereinfachen möchten, erreichen
 wir dies mit der ``simplify_full()`` Funktion::

     sage: (sin(x)^2 + cos(x)^2).simplify_full()
     1
 }}}

 Then the failing test mentions (I think) that `simplify_full()` will also
 do something with the logarithms:

 {{{
 Dabei werden auch Additionstheoreme für trigonometrische Funktionen und
 manche Logarithmengesetze eingesetzt::

     sage: var('x, y, z')
     (x, y, z)
     sage: (sin(x + y)/(log(x) + log(y))).simplify_full()
     (cos(y)*sin(x) + cos(x)*sin(y))/log(x*y)
     sage: (sin(x)^2 + cos(x)^2).simplify_full()
     1
 }}}

 but of course that's not the case anymore because the log contraction
 isn't necessarily valid if `x` or `y` is complex (what's the `z` for???).

 One possible solution would be to mention `simplify_real()` here. Note
 that the `sin^2 + cos^2 == 1` identity is mentioned and tested twice in a
 row. Maybe we could drop the second one, mention something about
 `simplify_real()` being used when the variables are real, and then show an
 example of,

 {{{
 sage: (log(x) + log(y)).simplify_real()
 log(x*y)
 }}}

 Another possible solution is to get rid of the `log()`s and just don't
 mention them. That takes slightly less creativity but does lose a useful
 example =)

--
Ticket URL: <http://trac.sagemath.org/ticket/17556#comment:3>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica, 
and MATLAB

-- 
You received this message because you are subscribed to the Google Groups 
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.

Reply via email to