#17556: Move simplify_log() from simplify_full() to simplify_real()
-------------------------------------+-------------------------------------
Reporter: mjo | Owner:
Type: enhancement | Status: positive_review
Priority: major | Milestone: sage-6.5
Component: symbolics | Resolution:
Keywords: | Merged in:
Authors: Michael Orlitzky | Reviewers: Ralf Stephan
Report Upstream: N/A | Work issues:
Branch: | Commit:
u/rws/ticket/17556 | 3616d00f582e175005d9b0182a1c1f4c124ebb56
Dependencies: | Stopgaps:
-------------------------------------+-------------------------------------
Changes (by rws):
* status: needs_work => positive_review
* commit: 044db1d2b7bc4e914e92ed7aa87629cbe958bc52 =>
3616d00f582e175005d9b0182a1c1f4c124ebb56
Comment:
Oops, should have used a public branch.
Replying to [comment:4 kcrisman]:
> Probably something like this would be appropriate (Ralf, I assume your
German is "more native" than mine and can confirm):
> {{{
> Mit der verwandten Funktion ``simplify_real()`` werden auch
Additionstheoreme ...
> }}}
> and then use `simplify_real()` there.
This patch adds such a test, and the sentence reads translated: `With the
related function simplify_real() also logarithmic addition theorems are
applied, which hold for real values.`
Since it's practically what you both proposed I'm including it with my
positive review.
----
New commits:
||[http://git.sagemath.org/sage.git/commit/?id=3616d00f582e175005d9b0182a1c1f4c124ebb56
3616d00]||{{{17556: reviewer's patch: adapt text and test to changed
behaviour}}}||
--
Ticket URL: <http://trac.sagemath.org/ticket/17556#comment:7>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.
