#5649: [with patch, positive review] plot doesn't work when x-range too small
----------------------+-----------------------------------------------------
Reporter: was | Owner: kcrisman
Type: defect | Status: assigned
Priority: major | Milestone: sage-4.1.1
Component: graphics | Keywords:
Reviewer: | Author:
Merged: |
----------------------+-----------------------------------------------------
Comment(by wcauchois):
REFEREE REPORT
I'd like to give this a positive review. Applies fine to Sage 4.1, and
plot tick marks work better now in a great many cases.
I feel like the readability of _tasteful_ticks() could be improved. Better
variable names would help ("d0", "d1", and "p" were hard to decipher). It
also looks like there is some duplicated code that could be factored out
into a separate method like maybe "extract_two_digits_and_place_value". We
can leave the refactor for another ticket perhaps :).
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/5649#comment:7>
Sage <http://sagemath.org/>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--~--~---------~--~----~------------~-------~--~----~
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected]
To unsubscribe from this group, send email to
[email protected]
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en
-~----------~----~----~----~------~----~------~--~---
