#16866: Radical difference families
-------------------------------------+-------------------------------------
       Reporter:  vdelecroix         |        Owner:
           Type:  enhancement        |       Status:  needs_info
       Priority:  major              |    Milestone:  sage-6.4
      Component:  combinatorial      |   Resolution:
  designs                            |    Merged in:
       Keywords:                     |    Reviewers:
        Authors:  Vincent Delecroix  |  Work issues:
Report Upstream:  N/A                |       Commit:
         Branch:                     |  721af75ec2b2c6ca904f2feaf86e75e054cb089d
  u/vdelecroix/16866                 |     Stopgaps:
   Dependencies:  #16863             |
-------------------------------------+-------------------------------------
Changes (by ncohen):

 * status:  needs_review => needs_info


Comment:

 Hello,

 I tried to simplify the explanations a bit but I still do not understand
 the implementation. In particular I do not understand why you have this
 `-1` in the definition of `A`, and why you seem to solve a tiling problem
 on `A` and not on `\Delta A`.

 Also, what would you think of removing the `one_cyclic_tiling` function?
 The name is not particularly meaningful, it is three lines long, only used
 once?...

 Could you also add your new functions to the index at the top of the file?

 My modifications can be found at `u/ncohen/16866`, but of course in that
 version your comments in the code use notations that I removed from the
 function's doc.

 I can change that once I understand the implementation better.

 Thanks,

 Nathann

--
Ticket URL: <http://trac.sagemath.org/ticket/16866#comment:14>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica, 
and MATLAB

-- 
You received this message because you are subscribed to the Google Groups 
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.

Reply via email to