#17583: Clean up free module elements
-------------------------------------+-------------------------------------
       Reporter:  jdemeyer           |        Owner:
           Type:  enhancement        |       Status:  needs_info
       Priority:  major              |    Milestone:  sage-6.5
      Component:  linear algebra     |   Resolution:
       Keywords:                     |    Merged in:
        Authors:  Jeroen Demeyer     |    Reviewers:  Marc Mezzarobba
Report Upstream:  N/A                |  Work issues:
         Branch:                     |       Commit:
  u/jdemeyer/ticket/17583            |  66d2f76d685f654f18b77f0051ae85235a4f846f
   Dependencies:  #17561             |     Stopgaps:
-------------------------------------+-------------------------------------

Comment (by jdemeyer):

 Replying to [comment:5 mmezzarobba]:
 > By the way, is there a reason to special-case the vectors of length zero
 in `FreeModuleElement.dot_product()`?
 Yes, to apply the following optimization: instead of starting with zero
 and `a[i]*b[i]`, we start with `a[0] * b[0]` and add `a[i]*b[i]` for `i >=
 1`.

 I'm actually preparing a commit which refactors dot products, since the
 logic was a bit strange. With the new commit (still testing), there will
 be a `cpdef` method `_dot_product_` for equal parents and
 `_dot_product_coerce_` for parents which might be different.

--
Ticket URL: <http://trac.sagemath.org/ticket/17583#comment:6>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica, 
and MATLAB

-- 
You received this message because you are subscribed to the Google Groups 
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.

Reply via email to