#13069: Generation of Double square tiles
-------------------------------------+-------------------------------------
Reporter: slabbe | Owner: slabbe
Type: enhancement | Status: needs_work
Priority: major | Milestone: sage-6.4
Component: combinatorics | Resolution:
Keywords: polyomino | Merged in:
Authors: Sébastien Labbé | Reviewers:
Report Upstream: N/A | Work issues:
Branch: | Commit:
public/ticket/13069 | 76783d6b6211eeaee0e9912c9389f222ac57849c
Dependencies: #10054, #13131 | Stopgaps:
-------------------------------------+-------------------------------------
Changes (by vdelecroix):
* status: needs_review => needs_work
Comment:
Hello,
* this is about tiling but we see only one tile at a time... For example,
it would be cool to have a parameter `translate` to `plot` in order to do:
{{{
sage: tile.plot(translate=(0,0)) + tile.plot(translate=(x,y))
}}}
* what is the point of `verify_definition`? I guess its only purpose is
for the constructor. If so
1. make it private
2. do not use assert but rather raise a `ValueError` if something is
wrong
* please consider moving `figure_11_BGL2012` to `sage/tests/`. It is not a
library function!
* you should really add definitions, I can not understand what this code
is doing. If you want to make it usable, then add documentation.
Otherwise, put everything into `sage/tests`
* can you fold `apply_reduction`, `reduce_ntimes` in one function. It
confuses to have different methods doing the same stuff.
* It is cool to have an `AUTHORS` section but please one line is enough:
{{{
- Alexandre Blondin Massé and Sébastien Labbé (2008-2013) - initial
version
}}}
* could you move `triple_square_example` to the examples at the begining
(i.e. within the documentation)? or it is important to have it as a
standalone function in the library?
More to come
Vincent
--
Ticket URL: <http://trac.sagemath.org/ticket/13069#comment:19>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.
