#17695: Slightly fasten is_cyclotomic()
-------------------------------------+-------------------------------------
Reporter: bruno | Owner:
Type: enhancement | Status: needs_review
Priority: minor | Milestone: sage-6.5
Component: number theory | Resolution:
Keywords: cyclotomic | Merged in:
polynomials | Reviewers:
Authors: Bruno Grenet | Work issues:
Report Upstream: N/A | Commit:
Branch: | f79eeaaa630b1bd966a25a2f7b0f7a5f1dda3378
u/bruno/slightly_fasten_is_cyclotomic__| Stopgaps:
Dependencies: |
-------------------------------------+-------------------------------------
Changes (by bruno):
* keywords: => cyclotomic polynomials
* commit: => f79eeaaa630b1bd966a25a2f7b0f7a5f1dda3378
* status: new => needs_review
Old description:
> In `src/sage/rings/polynomial/polynomial_element.pyx`, the method
> `is_cyclotomic()` begins with checking the irreducibility of the input
> polynomial, and then checks the leading and constant coefficients. I
> simply propose to invert those tests to fasten a bit the test for
> polynomials that are not monic or whose constant coefficient is not `1`.
New description:
In `src/sage/rings/polynomial/polynomial_element.pyx`, the method
`is_cyclotomic()` begins by checking the irreducibility of the input
polynomial, and then checks the leading and constant coefficients. I
simply propose to invert those tests to fasten a bit the test for
polynomials that are not monic or whose constant coefficient is not `1`.
--
--
Ticket URL: <http://trac.sagemath.org/ticket/17695#comment:2>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.
