#17695: Slightly fasten is_cyclotomic()
-------------------------------------+-------------------------------------
Reporter: bruno | Owner:
Type: enhancement | Status: needs_review
Priority: minor | Milestone: sage-6.5
Component: number theory | Resolution:
Keywords: cyclotomic | Merged in:
polynomials | Reviewers:
Authors: Bruno Grenet | Work issues:
Report Upstream: N/A | Commit:
Branch: | f79eeaaa630b1bd966a25a2f7b0f7a5f1dda3378
u/bruno/slightly_fasten_is_cyclotomic__| Stopgaps:
Dependencies: |
-------------------------------------+-------------------------------------
Comment (by bruno):
Replying to [comment:6 vdelecroix]:
> Replying to [comment:5 bruno]:
> > Replying to [comment:3 vdelecroix]:
> > It is not surprising indeed that Pari is faster for this. I don't
understand what you mean by
> > > either call Pari or stick to their implementation.
> > Do you mean there are two ways to use Pari's implementation?
>
> Nope. Either we should copy their implementation within Sage (I do not
think this is justified) or just call Pari.
>
> And by the way there are two ways of using pari. Either with `gp` (this
is a pexpect interface with a lot of latency in communication) and with
`libpari` (which is very efficient in C). But sadly there is not yet
`poliscyclo` and `poliscycloprod` in the libpari interface (i.e. in the
file `libs/pari/gen.pyx`). I guess that we should wait for #17631 and not
modify `gen.pyx` directly.
>
> Vincent
For concreteness, what do you propose to do now? If I understand
correctly, you propose to wait for #17631 and then make `is_cyclotomic()`
directly call the pari functions, and not introduce the tiny change I
made? I am fine with that, just wanted to be sure!
--
Ticket URL: <http://trac.sagemath.org/ticket/17695#comment:9>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.
