#15346: Symbolic sums should evaluate
-------------------------+-------------------------------------------------
       Reporter:         |        Owner:
  kcrisman               |       Status:  needs_review
           Type:         |    Milestone:  sage-6.4
  defect                 |   Resolution:
       Priority:  major  |    Merged in:
      Component:         |    Reviewers:  Karl-Dieter Crisman
  symbolics              |  Work issues:
       Keywords:         |       Commit:
        Authors:  Ralf   |  cb78603878bc1a7443e982824e13c81e22e9edda
  Stephan                |     Stopgaps:
Report Upstream:  N/A    |
         Branch:         |
  u/rws/15346            |
   Dependencies:         |
-------------------------+-------------------------------------------------
Changes (by kcrisman):

 * cc: mjo (added)
 * reviewer:   => Karl-Dieter Crisman


Comment:

 As I suspected, the addition of the log thing led to some issues.  Is this
 'simplification' always valid for complex numbers?  I know mjo has been
 very good at thinking about this kind of thing, cc:ing him.
 {{{

 File "src/sage/symbolic/expression.pyx", line 8249, in
 sage.symbolic.expression.Expression.simplify_full
 Failed example:
     f.simplify_full()
 Expected:
     log(x*y) - log(x) - log(y)
 Got:
     0
 **********************************************************************
 File "src/sage/modules/vector_symbolic_dense.py", line 19, in
 sage.modules.vector_symbolic_dense
 Failed example:
     u.simplify_full()
 Expected:
     (1, log(3*y) + log(2*y))
 Got:
     (1, log(6*y^2))
 **********************************************************************
 }}}
 Naturally, this is orthogonal to the main issue, but I think it should be
 in a different ticket unless it's very obvious it's okay.

 As to the main question, I think my only question is whether this should
 definitely be incorporated in `simplify_full`.  Can anyone think of a
 reason ''not'' to do so?  I'm straining my brain to be creative here - for
 instance, if it should make a really really really long expression which
 isn't "simpler"?  I can't find it but there was some Maxima comment about
 the massive length of some such expressions.  My druthers would be to keep
 this separate from `simplify_full` for now, though I understand the
 reasons ''for'' doing it!

--
Ticket URL: <http://trac.sagemath.org/ticket/15346#comment:18>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica, 
and MATLAB

-- 
You received this message because you are subscribed to the Google Groups 
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.

Reply via email to