#17712: Adds memoization to the branch and bound for vertex separation
-------------------------+-------------------------------------------------
Reporter: | Owner:
dcoudert | Status: needs_work
Type: | Milestone: sage-6.5
enhancement | Resolution:
Priority: minor | Merged in:
Component: graph | Reviewers:
theory | Work issues:
Keywords: | Commit:
Authors: David | 1a33d044aa565ef4ea574d33d8010c634a17699a
Coudert | Stopgaps:
Report Upstream: N/A |
Branch: |
public/17112 |
Dependencies: |
#17711 |
-------------------------+-------------------------------------------------
Changes (by ncohen):
* status: needs_review => needs_work
Comment:
Hello David,
A short review before going to sleep:
1) You do not seem to do anything at all with `max_prefix_number`.
2) You add parameters in `path_decomposition` but you don't do
anything with them.
3) Given that you seem to only store sets of integers, I am
tempted to think that you should prefer `FrozenBitset` objects
over `frozenset`. They should give you a faster hash/equality
test.
4) There are many empty docstrings in the methods of
`PrefixStorage`. And to be honest, considering the amount of doc
it takes to implement all of that, I wonder if it would not be
better to leave it all in the code, without creating a new
class. "Just a dictionary whose keys are bitsets".
In order to not have too many things in the actual
branch-and-bound, it may be enough to have just a couple of
functions (your update/is_known_prefix) taking a dictionary as an
additional argument.
Good night,
Nathann
--
Ticket URL: <http://trac.sagemath.org/ticket/17712#comment:5>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.
