#17712: Adds memoization to the branch and bound for vertex separation
-------------------------+-------------------------------------------------
Reporter: | Owner:
dcoudert | Status: needs_review
Type: | Milestone: sage-6.5
enhancement | Resolution:
Priority: minor | Merged in:
Component: graph | Reviewers:
theory | Work issues:
Keywords: | Commit:
Authors: David | 6e39f78fbdfcf22ca89ba23ac96ce88431feaa6e
Coudert | Stopgaps:
Report Upstream: N/A |
Branch: |
public/17112 |
Dependencies: |
#17711 |
-------------------------+-------------------------------------------------
Comment (by ncohen):
Hello again,
I am working again on this patch, and I cannot say that I like this
`PrefixStorage` class very much. To make it simple it is just a
dictionary, in which you seem to store all values that you do not want to
carry around as parameters of the `BAB_C` function.
Some parameters are almost impossible to document in the `PrefixStorage`
class and can only be understood if you know exactly where they are called
from the inside of the `BAB_C` function.
I removed some undocumented functions from `PrefixStorage` that you did
not call (as well as the undocumented `__len__`). Please make sure that
`sage -coverage <file>` does not return anything wrong before you submit a
patch for review.
....
Okay, and I just noticed that you pushed a new commit on this
`needs_review` patch. So now I will see whether it breaks all my
modifications.
Today is not a good day.
Nathann
----
New commits:
||[http://git.sagemath.org/sage.git/commit/?id=6e39f78fbdfcf22ca89ba23ac96ce88431feaa6e
6e39f78]||{{{trac #17712: remove parameter enable_prefix_storage}}}||
--
Ticket URL: <http://trac.sagemath.org/ticket/17712#comment:10>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.
