#17695: Slightly fasten is_cyclotomic()
-------------------------------------+-------------------------------------
Reporter: bruno | Owner:
Type: enhancement | Status: needs_review
Priority: minor | Milestone: sage-6.5
Component: number theory | Resolution:
Keywords: cyclotomic | Merged in:
polynomials | Reviewers:
Authors: Bruno Grenet | Work issues:
Report Upstream: N/A | Commit:
Branch: u/bruno/17695 | 85d8ffcdd69d911dcc042e4dd3ab8374f90e4d56
Dependencies: | Stopgaps:
-------------------------------------+-------------------------------------
Changes (by bruno):
* commit: 90ac73a342710459415a32442d418751e3560be6 =>
85d8ffcdd69d911dcc042e4dd3ab8374f90e4d56
Comment:
Replying to [comment:25 vdelecroix]:
> Actually, the factor at the end is overkill as we only want a square
root. I did have a look at the method `.is_square()` and it was dirty
enough to be slow. So I just make it simpler/clearer. The speedup is very
small and concerns mostly positive cases.
>
> I am happy with your commits. Just review mine.
I am fine with your commit too, but for one typo that I've corrected in
the docstring of `is_square()`:
{{{#!diff
def is_square(self, root=False):
"""
Returns whether or not polynomial is square. If the optional
- argument ``root`` is set to ``True, then also returns the square root
+ argument ``root`` is set to ``True``, then also returns the square root
(or ``None``, if the polynomial is not square).
}}}
I do not know whether it is acceptable for me to set "positive review". I
let you do so if you consider everything's OK. Thanks for the patient
feedback!
----
New commits:
||[http://git.sagemath.org/sage.git/commit/?id=85d8ffcdd69d911dcc042e4dd3ab8374f90e4d56
85d8ffc]||{{{Review commit}}}||
--
Ticket URL: <http://trac.sagemath.org/ticket/17695#comment:27>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.
