#17695: Slightly fasten is_cyclotomic()
-------------------------------------+-------------------------------------
Reporter: bruno | Owner:
Type: enhancement | Status: needs_review
Priority: minor | Milestone: sage-6.5
Component: number theory | Resolution:
Keywords: cyclotomic | Merged in:
polynomials | Reviewers:
Authors: Bruno Grenet | Work issues:
Report Upstream: N/A | Commit:
Branch: | 90ac73a342710459415a32442d418751e3560be6
u/vdelecroix/17695 | Stopgaps:
Dependencies: |
-------------------------------------+-------------------------------------
Changes (by vdelecroix):
* commit: 1b01fad201f72a254845e763cf8b072d28cde8b8 =>
90ac73a342710459415a32442d418751e3560be6
* branch: u/bruno/slightly_fasten_is_cyclotomic__ => u/vdelecroix/17695
Comment:
Actually, the factor at the end is overkill as we only want a square root.
I did have a look at the method `.is_square()` and it was dirty enough to
be slow. So I just make it simpler/clearer. The speedup is very small and
concerns mostly positive cases.
I am happy with your commits. Just review mine.
Vincent
----
New commits:
||[http://git.sagemath.org/sage.git/commit/?id=90ac73a342710459415a32442d418751e3560be6
90ac73a]||{{{trac #17695: simplify factor step + faster .sqrt()}}}||
--
Ticket URL: <http://trac.sagemath.org/ticket/17695#comment:25>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.
