#16926: Merge the features of SymmetricGroupAlgebra and SymmetricGroup.algebra
-------------------------------------+-------------------------------------
Reporter: nthiery | Owner:
Type: enhancement | Status: needs_review
Priority: major | Milestone: sage-6.4
Component: combinatorics | Resolution:
Keywords: | Merged in:
Authors: Travis Scrimshaw | Reviewers:
Report Upstream: N/A | Work issues:
Branch: | Commit:
public/combinat/fix_sga-16926 | f15f40cd95cd94cd3e4a3b843fd0b257746d43f0
Dependencies: | Stopgaps:
-------------------------------------+-------------------------------------
Comment (by darij):
Not sure if I'm going to be reviewing this (time is short as usual and I'm
still not good at OOP -- case in point, I don't know what mixins are for),
but a few remarks.
First, a trivial group needs no generators. So this
{{{
+ if self.n <= 1:
+ return (self.one(),)
}}}
can be replaced by
{{{
+ if self.n <= 1:
+ return ()
}}}
Second, you are testing for the order-of-multiplication global in
`has_left_descent` and in `has_right_descent`. I understand the reasoning
behind it, but I don't like it. Can we agree that the "left" in "left
descent" stands for "left action" rather than "multiplying with s_i from
the left", or is this too revisionistic?
--
Ticket URL: <http://trac.sagemath.org/ticket/16926#comment:16>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.
