#17740: Division of modules by basering elements should not pass to the fraction
field.
-------------------------------------+-------------------------------------
Reporter: robertwb | Owner:
Type: defect | Status: needs_info
Priority: major | Milestone: sage-6.5
Component: coercion | Resolution:
Keywords: | Merged in:
Authors: | Reviewers:
Report Upstream: N/A | Work issues:
Branch: | Commit:
u/vdelecroix/17440 | 96c1a0348964c4edbd42f3fc52e93b9e76f26156
Dependencies: | Stopgaps:
-------------------------------------+-------------------------------------
Changes (by vdelecroix):
* status: needs_review => needs_info
* commit: 1e88c72687b89713e3ca79e435c509c0d99bece2 =>
96c1a0348964c4edbd42f3fc52e93b9e76f26156
* branch: u/robertwb/coerce-div => u/vdelecroix/17440
Comment:
I wrote trivial commits while I was reading the code. One thing to
mention: in the documentation you should use {{{:trac:`17440`}}} instead
of `#17440`.
One last question: in `coerce.pyx`, you wrote
{{{
try:
return ~right_mul
except TypeError: # action may not be invertible
self._record_exception()
}}}
Shouldn't we catch only `CoercionException`?
----
New commits:
||[http://git.sagemath.org/sage.git/commit/?id=a60134cdb45ad44725efb637f6b4fec74077197f
a60134c]||{{{trac #17740: review 1 (documentation)}}}||
||[http://git.sagemath.org/sage.git/commit/?id=728811d3f2f1d46750775b2e9ac203c08ef6db82
728811d]||{{{trac #17740: review 2 (clean Errors)}}}||
||[http://git.sagemath.org/sage.git/commit/?id=96c1a0348964c4edbd42f3fc52e93b9e76f26156
96c1a03]||{{{trac #17740: review 3 (less in try/except block)}}}||
--
Ticket URL: <http://trac.sagemath.org/ticket/17740#comment:10>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.
