#5793: [with patch, needs work] New algorithm for Max Clique in Graph class
using
Cython
--------------------------+-------------------------------------------------
Reporter: ncohen | Owner: rlm
Type: enhancement | Status: reopened
Priority: minor | Milestone: sage-4.1.1
Component: graph theory | Resolution:
Keywords: | Reviewer:
Author: | Merged:
--------------------------+-------------------------------------------------
Comment(by rlm):
Nathann,
I have deleted the previous patches to avoid confusion.
When addressing the following issues, please post another patch to be
applied on top of the first (this makes review easier).
1. `algorithm=='networkx'` is never tested, and if it were, it would fail,
due to the `cliques` parameter
2. Why are you using `cliquer.pxi` instead of `cliquer.pxd`? If it were
`pxd` instead, then other Cython files could `cimport` the same data
types.
3. It should go:
{{{
if algorithm=='networkx':
...
elif algorithm=='cliquer':
...
else:
raise NotImplementedError("Only 'networkx' and 'cliquer' are
supported.")
}}}
Also you need to change one instance of `'Cliquer'` to `'cliquer'`.
4. In maximum_cliques, "vertex set" should be "vertex sets"
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/5793#comment:14>
Sage <http://sagemath.org/>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--~--~---------~--~----~------------~-------~--~----~
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected]
To unsubscribe from this group, send email to
[email protected]
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en
-~----------~----~----~----~------~----~------~--~---
