#17814: Make calling a cached method independent of source code inspection
-------------------------------------+-------------------------------------
Reporter: SimonKing | Owner:
Type: defect | Status: needs_review
Priority: major | Milestone: sage-6.6
Component: distribution | Resolution:
Keywords: | Merged in:
Authors: Simon King | Reviewers:
Report Upstream: N/A | Work issues:
Branch: | Commit:
u/SimonKing/make_calling_a_cached_method_independent_of_source_code_inspection|
a0b829dc10b4ccb00b99e073de8a1c0006aa1e51
Dependencies: | Stopgaps:
-------------------------------------+-------------------------------------
Comment (by SimonKing):
Replying to [comment:50 nbruin]:
> It's unfortunate: all the required objects already exist in the cython
code, there are just no hooks to attach them to.
That's why I suggest to have a practical fix that works for now. Recall
that the problem from the ticket description came from a report on sage-
devel, where people actually work with flavours of Sage that come without
the source code.
I think that the current branch does not have a high danger of creating
subtle caching problems. First of all, with the branch, a change in
behaviour can only occur when we have a cached method-with-default-
arguments-and/or-args/kwds of a cdef class whose source file is not
available. Methods without arguments will be totally fine if the source
file is gone (so, the branch does fix a problem).
A change in behaviour would most likely be a problem where coercion is
involved, i.e., in `UniqueRepresentation`. But there, we are safe, since
(a) sub-classes of `UniqueRepresentation` must be Python classes anyway
(and Python classes aren't affected by the bug), and (b)
`UniqueRepresentation.__classcall__` has generic arguments `*args,**kwds`.
If you think that it is too dangerous to silently change behaviour rather
than raise a straight forward error, we could instead raise a warning
(only once, similar to deprecation warnings) when a cached method is
called on a method whose argspec can't be determined.
--
Ticket URL: <http://trac.sagemath.org/ticket/17814#comment:51>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.
