#17814: Make calling a cached method independent of source code inspection
-------------------------------------+-------------------------------------
Reporter: SimonKing | Owner:
Type: defect | Status: needs_review
Priority: major | Milestone: sage-6.6
Component: distribution | Resolution:
Keywords: | Merged in:
Authors: Simon King | Reviewers:
Report Upstream: N/A | Work issues:
Branch: | Commit:
u/SimonKing/make_calling_a_cached_method_independent_of_source_code_inspection|
a0b829dc10b4ccb00b99e073de8a1c0006aa1e51
Dependencies: | Stopgaps:
-------------------------------------+-------------------------------------
Comment (by nbruin):
Replying to [comment:51 SimonKing]:
> I think that the current branch does not have a high danger of creating
subtle caching problems. First of all, with the branch, a change in
behaviour can only occur when we have a cached method-with-default-
arguments-and/or-args/kwds of a cdef class whose source file is not
available. Methods without arguments will be totally fine if the source
file is gone (so, the branch does fix a problem).
I agree the danger is "not high" but it's not zero either. Subtle
deviations like this are the source of incredibly difficult-to-replicate
issues later on, because the reporter will of course forget to report that
this is a sourceless distribution. (Perhaps it's not so bad: the bug will
just be ignored because we can't replicate it)
I'm not so sure a warning is an option: I'd expect that the first
occurrence would be during system startup, so the warning might get lost.
Anyway, I think the fact that we look at the source at all in order to
figure out how to preprocess the arguments is a deficiency. I'd prefer if
we can use this ticket to track the resolution of that, but if this issue
is really urgent for some users, I guess we can merge something along the
lines of what you propose.
I expect that we'll find a cython-based solution, possibly docstring
based. It might be a configure option to select if you want this extra
data in your docstrings, but in sage we probably would, since we process
the docstrings for display anyway.
--
Ticket URL: <http://trac.sagemath.org/ticket/17814#comment:52>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.
