#5793: [with patch, needs work] New algorithm for Max Clique in Graph class 
using
Cython
--------------------------+-------------------------------------------------
 Reporter:  ncohen        |        Owner:  rlm       
     Type:  enhancement   |       Status:  reopened  
 Priority:  minor         |    Milestone:  sage-4.1.1
Component:  graph theory  |   Resolution:            
 Keywords:                |     Reviewer:            
   Author:                |       Merged:            
--------------------------+-------------------------------------------------

Comment(by rlm):

 OK, I have a few more requests:

 1. I think you should expose Cliquer's `graph_print` function in
 `cliquer.pxd`, so other people see it when they try to play around with
 the interface.

 2. In general, doctests should be indented, so e.g.
 {{{
 EXAMPLES::

 sage: C=graphs.PetersenGraph()
 sage: max_clique(C)
 [7, 9]
 """
 }}}
 should be
 {{{
 EXAMPLES::

     sage: C=graphs.PetersenGraph()
     sage: max_clique(C)
     [7, 9]

 """
 }}}

 3. In fact, you should probably check out

 http://www.sagemath.org/doc/developer/conventions.html

 For example, the following belongs in an `INPUT:` block, and would look
 much more professional there:

 {{{
 The parameter 'cliques' is an optional list of cliques that can be input
 if already computed.
 ONLY USED BY NetworkX !!!
 }}}

 4. There are several functions in `graph.py` which compute with cliques,
 which haven't been exposed to this new interface. For example,
 `G.cliques()`. It would be nice to take care of those functions now too,
 so people don't unnecessarily complain about these functions being slow
 later. They are all in the same part of the file, which starts with `###
 Cliques`.

-- 
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/5793#comment:25>
Sage <http://sagemath.org/>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica, 
and MATLAB

--~--~---------~--~----~------------~-------~--~----~
You received this message because you are subscribed to the Google Groups 
"sage-trac" group.
To post to this group, send email to [email protected]
To unsubscribe from this group, send email to 
[email protected]
For more options, visit this group at 
http://groups.google.com/group/sage-trac?hl=en
-~----------~----~----~----~------~----~------~--~---

Reply via email to